Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 improve tilt setup for local e2e #10467

Merged
merged 1 commit into from
May 2, 2024
Merged

🌱 improve tilt setup for local e2e #10467

merged 1 commit into from
May 2, 2024

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Apr 19, 2024 •
edited
Loading

What this PR does / why we need it:
adds a convenience make target for preparing local environment for testing. stitches together a few things that are required but not entirely obvious

related slack thread: https://kubernetes.slack.com/archives/C8TSNPY4T/p1713359007536259

/area testing

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Issues or PRs related to testing labels Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024
cahillsf
cahillsf commented Apr 19, 2024
View reviewed changes
scripts/ci-build-kind.sh Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copy/paste from https://github.com/kubernetes-sigs/cluster-api/blob/main/scripts/ci-e2e.sh

only runs a portion of it since it's for convenience of running tilt and local kind cluster. open to suggestions for a better approach

chrischdi
chrischdi reviewed Apr 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Apr 29, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Apr 29, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@cahillsf
Copy link
Member Author

cahillsf commented Apr 29, 2024 •
edited
Loading

just pushed up some changes based on the feedback above -- lmk what you think

@fabriziopandini
Copy link
Member

lgtm for me

@sbueringer
Copy link
Member

Should we un-draft this PR?

sbueringer
sbueringer reviewed Apr 30, 2024
View reviewed changes
scripts/ci-build-kind.sh Outdated Show resolved Hide resolved
scripts/ci-build-kind.sh Outdated Show resolved Hide resolved
@cahillsf cahillsf marked this pull request as ready for review April 30, 2024 12:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@sbueringer
Copy link
Member

Thx!

/approve

/assign @fabriziopandini @chrischdi

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
chrischdi
chrischdi reviewed May 2, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c603ed1305b5a18c96d1b551080d09ef434356e

@k8s-ci-robot k8s-ci-robot merged commit 8e8cf93 into kubernetes-sigs:main May 2, 2024
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@cahillsf @k8s-ci-robot @fabriziopandini @sbueringer @chrischdi