Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Tinkerbell to the providers list #10487

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

oprinmarius
Copy link
Member

@oprinmarius oprinmarius commented Apr 22, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10486

/area clusterctl

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2024
@oprinmarius
Copy link
Member Author

/retest-failed

@oprinmarius
Copy link
Member Author

/retest

@oprinmarius oprinmarius changed the title ✨ Add Tinkerbell to the providers list 🌱 Add Tinkerbell to the providers list Apr 23, 2024
@oprinmarius
Copy link
Member Author

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl and removed do-not-merge/needs-area PR is missing an area label labels Apr 23, 2024
cmd/clusterctl/client/config/providers_client.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member

Q: by a quick at the provider web site the latest supported version is K8s 1.22, which is well under support.
Are we sure we want to continue with this PR

@oprinmarius
Copy link
Member Author

Q: by a quick at the provider web site the latest supported version is K8s 1.22, which is well under support. Are we sure we want to continue with this PR

I think the docs are outdated. I am currently using this provider like this:

providers:
  - name: "tinkerbell"
    url: "https://github.com/tinkerbell/cluster-api-provider-tinkerbell/releases/latest/infrastructure-components.yaml"
    type: "InfrastructureProvider"
EOF
export TINKERBELL_IP=<hegel ip>
clusterctl init --infrastructure tinkerbell

I would like to have the ability to deploy this with the Helm chart from https://github.com/kubernetes-sigs/cluster-api-operator and avoid using custom manifests

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c10882e2c6220c5c9139beedec3d708c411a53e1

@sbueringer
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

Thx!

/approve

@sbueringer
Copy link
Member

/cherry-pick release-1.7

To make it usable soon'ish.

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

To make it usable soon'ish.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 25, 2024
@sbueringer
Copy link
Member

sbueringer commented Apr 25, 2024

@oprinmarius There was another very similar PR that just merged (for another provider). Can you please rebase this PR onto latest main?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
@oprinmarius
Copy link
Member Author

@sbueringer I rebased with latest main, can you please /approve and /lgtm again . Labels were removed.

I noticed this test is flaky https://github.com/kubernetes-sigs/cluster-api/actions/runs/8833373455/job/24252531701?pr=10487
It appears that https://azure.microsoft.com/en-us/products/kubernetes-service is sometimes a dead link

/retest

@sbueringer
Copy link
Member

Yup, that link is really flaky

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 72e46ee9da199c76a2d78ad85e021c73847356a5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 25, 2024
@sbueringer
Copy link
Member

@jackfrancis Sorry I know that's really a pretty random request :D. Do you think there's any way that that link can be made more stable? 😂 ("https://azure.microsoft.com/en-us/products/kubernetes-service")

It fails relatively regularly with our markdown linkchecker. We could also just simply put it on the ignore list to skip verifying it every time.

@k8s-ci-robot k8s-ci-robot merged commit 4049b31 into kubernetes-sigs:main Apr 25, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 25, 2024
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #10516

In response to this:

/cherry-pick release-1.7

To make it usable soon'ish.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tinkerbell provider
6 participants