Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Push manifests for main & release-.* #10521

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Apr 26, 2024

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This target is run on main and all release-branches (https://github.com/kubernetes/test-infra/blob/996976242b664e8f55ce6873692b0ebc2da5de02/config/jobs/image-pushing/k8s-staging-cluster-api.yaml#L13).

While we already have images like: gcr.io/k8s-staging-cluster-api/cluster-api-controller:release-1.7, gcr.io/k8s-staging-cluster-api/cluster-api-controller:main available. This PR will give us corresponding manifests.

This should make it very easy for folks to consume manifests / images based on the last commit of main and release branches.

Bonus: we'll also get manifests for release tags in the staging bucket.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@sbueringer
Copy link
Member Author

/assign @chrischdi

@sbueringer
Copy link
Member Author

cc @nrb @damdo Maybe interesting for you

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

/lgtm
/approve
/area release

/hold

(just in case)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/release Issues or PRs related to releasing labels Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-area PR is missing an area label labels Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ae70053e4fa118d0114279d50db8b8e94ed4094

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/hold cancel

Let's give it a try :D

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit eafea49 into kubernetes-sigs:main Apr 26, 2024
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 26, 2024
@sbueringer sbueringer deleted the pr-push-branch-manifests branch April 26, 2024 09:29
@sbueringer
Copy link
Member Author

Worked 🎉

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants