-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Ensure resourceVersions are stable #10530
Conversation
Tested locally and it works. Might need some fine-tuning after merge though |
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer [email protected]
45cf6d4
to
bdd8ba2
Compare
/test pull-cluster-api-e2e-main |
Nice! |
LGTM label has been added. Git tree hash: cc0ec5ff44e8758b0813edf77e735e955ceda3b8
|
/test pull-cluster-api-e2e-main (one more time to verify how stable it is) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.7 So this can be used to extend test coverage in providers |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #10548 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR ensures resourceVersions are stable after the quick start tests.
The goal is to detect if some of our controllers are continuously reconcililng objects (and bumping resource versions)
Related: kubernetes/kubernetes#124605
I'll open a corresponding CAPI issue to track the k/k issue soon.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Helps to mitigate #10533