-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Skip publishing the RemediationRestricted
event when there are no unhealthy target
#10591
🐛 Skip publishing the RemediationRestricted
event when there are no unhealthy target
#10591
Conversation
Hi @Levi080513. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5db9173
to
ec15add
Compare
RemediationRestricted
eventType when there are no unhealthy targetRemediationRestricted
eventType when there are no unhealty target
RemediationRestricted
eventType when there are no unhealty targetRemediationRestricted
eventType when there are no unhealty target
ec15add
to
65c27b4
Compare
Thanks! |
LGTM label has been added. Git tree hash: 70a04b05e6a21a1d1751700eab334e4d33fc2410
|
internal/controllers/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
65c27b4
to
b973a05
Compare
b973a05
to
3e589fc
Compare
RemediationRestricted
eventType when there are no unhealty targetRemediationRestricted
event when there are no unhealthy target
/lgtm /assign @enxebre |
LGTM label has been added. Git tree hash: a9bcc65450f66e50ee50fe92b710746bf5b2b62f
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can this PR cherry pick to 1.6? The main version we are currently using is still 1.6. |
Fine for me |
/cherry-pick release-1.7 |
/cherry-pick release-1.6 |
@sbueringer: new pull request created: #10616 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@sbueringer: new pull request created: #10617 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
When there are no unhealthy target, skip publishing the
RemediationRestricted
event to avoid misleading.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # #10585
/area machinehealthcheck