-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use kind as a secondary management cluster for clusterctl E2E tests #10639
🌱 Use kind as a secondary management cluster for clusterctl E2E tests #10639
Conversation
666cb6f
to
756980c
Compare
Check if there are regressions |
/test pull-cluster-api-e2e-main |
one more run |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
206038c
to
55aa0c4
Compare
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-main To run the tests and for me to compare the artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all a great improvement.
Waiting to compare the output artifacts though :-)
Here you can find logs from a management cluster using real infrastructure: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-main/1792914324948258816/artifacts/clusters/clusterctl-upgrade-2r960q/ Here you can find logs from a management cluster using kind: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/10639/pull-cluster-api-e2e-main/1791517726108291072/artifacts/clusters/clusterctl-upgrade-management-31y0ec/ We have logs from controllers, CAPI resources metrics Also, when using kind, you wont find a namespace for this test in the bootsrap cluster |
/lgtm The ones I wanted to look for were e.g. these: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/10639/pull-cluster-api-e2e-main/1792889525148585984/artifacts/clusters/clusterctl-upgrade-management-95kq15/resources/clusterctl-upgrade/Cluster/ looks great! Thanks |
LGTM label has been added. Git tree hash: ec87a11899ff41234fb825ad72938bc64d850c8c
|
/test pull-cluster-api-e2e-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
/cherry-pick release-1.7 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 383d0dc38d427f662ced736ca76c3ca68c25f76a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: #10639 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…kubernetes-sigs#10639) * Use kind as a secondary management cluster for clusterctl E2E tests * Use kind in all clusterctl tests * Fix lint * Address comments
…kubernetes-sigs#10639) * Use kind as a secondary management cluster for clusterctl E2E tests * Use kind in all clusterctl tests * Fix lint * Address comments
What this PR does / why we need it:
This PR allow clusterctl E2E tests to use kind as a secondary management cluster (instead of using expensive infrastructure resources)
Which issue(s) this PR fixes:
Fixes #7613
/area testing