-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use k8s.io/utils/ptr instead of k8s.io/utils/pointer #10700
Conversation
Signed-off-by: sivchari <[email protected]>
/lgtm /area cleanup |
@chrischdi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM label has been added. Git tree hash: a235fc0da83d6dbac293afa1a283d01cd3806437
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
/hold |
Not sure what our policy is with making changes to v1alpha3 now - but hold in case we have some issue with this. IMO v1alpha3 as we have it is |
It's okay. We intentionally only restored it under internal and it is only used for conversion. For conversion this change doesn't matter at all. It also doesn't have any impact on the CRDs (which is the only thing from v1alpha3 surfaced to our users) /hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #