🌱 Fix finalizers assertions #10735
🌱 Fix finalizers assertions #10735
Conversation
k8s-ci-robot
added
area/e2e-testing
|
/test |
|
@fabriziopandini: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-main |
| @@ -67,12 +69,14 @@ func ValidateOwnerReferencesOnUpdate(ctx context.Context, proxy ClusterProxy, na | |||
| forceClusterResourceSetReconcile(ctx, proxy.GetClient(), namespace) | |||
|
|
|||
| // Check that the ownerReferences have updated their apiVersions to current versions after reconciliation. | |||
| byf("Check that the ownerReferences are rebuilt as expected") | |||
| AssertOwnerReferences(namespace, proxy.GetKubeconfigPath(), ownerGraphFilterFunction, assertFuncs...) | |||
There was a problem hiding this comment.
Can you please change all Expect within the Eventually in this func to use the Gomega from here: Eventually(func(g Gomega) error {
If I see correctly it's only one in l.129 but please double check
There was a problem hiding this comment.
@sbueringer PTAL
fabriziopandini
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cd2d0f86b085ba89be796679401f7470d1dd2b17
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Fix/cleanup finalizer assertions so they wait until the
Eventuallytimeout expires + print some more logs.Area example:
/area e2e-testing