Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Ensure unhealthy machines get deletion priority #10755

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jun 14, 2024

What this PR does / why we need it:
We recently merged #10712 under the assumption that when deleting machines on older MachineSets, unhealthy machines were prioritized.

This is only true for machines with NodeHealthy not set or false, but not for machines with HealthCheckSucceeded set to false by MHC.

This PR fixes this, and thus ongoing rollouts now contribute to a faster remediation of unhealthy machines.

/area machineset

cc @vincepri @enxebre @sbueringer

@k8s-ci-robot k8s-ci-robot added area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2024
@enxebre
Copy link
Member

enxebre commented Jun 14, 2024

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03466455e30cbdf85b9dd03a1d21b104caf50b68

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@sbueringer
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2024
@sbueringer
Copy link
Member

Let's please finish the discussion here: #10755 (comment)

It might be all good, but the reasoning atm is not correct.

@k8s-ci-robot k8s-ci-robot merged commit 1cca490 into kubernetes-sigs:main Jun 14, 2024
33 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jun 14, 2024
@vincepri
Copy link
Member

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot

@vincepri: new pull request created: #10761

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants