Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Bump to controller-runtime v0.19 & controller-tools v0.16 #10803

Merged
merged 10 commits into from
Aug 15, 2024
Merged

✨ Bump to controller-runtime v0.19 & controller-tools v0.16 #10803

merged 10 commits into from
Aug 15, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 27, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10653

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
@sbueringer sbueringer changed the title [WIP] Bump to CR main [WIP] ✨ Bump to CR main Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2024
@sbueringer sbueringer mentioned this pull request Jul 1, 2024
Merged
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 1, 2024
@sbueringer sbueringer added this to the v1.9 milestone Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
@sbueringer sbueringer added the area/dependency Issues or PRs related to dependency changes label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-area PR is missing an area label labels Jul 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2024
@sbueringer sbueringer mentioned this pull request Jul 16, 2024
Closed
@sbueringer sbueringer changed the title [WIP] ✨ Bump to CR main [WIP] ✨ Bump to CR & CT main Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 6, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-mink8s-main

@sbueringer
Bump to controller-runtime v0.19, controller-tools v0.16.1, k8s.io/*
6c295a2 
1.30

Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Bump controller-gen & conversion-gen
02cbf39 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Adjust utilfeature.SetFeatureGateDuringTest calls
46be128 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Adjust clusterctl to changes in kubectl
a01e278 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Adjust to generic changes in controller-runtime
1feaf74 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Ensure TODOs in API types are single line
4682c6b 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Ensure lastTransitionTime stays optional in v1alpha3 & v1alpha4
1170de4 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Improve CEL variable unit tests
9287c81 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer
Regenerate CRDs
ccd16eb
@sbueringer
Regenerate roles
ea6be50
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-31-1-32-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-31-1-32-main

@sbueringer sbueringer changed the title [WIP] ✨ Bump to controller-runtime v0.19 & controller-tools v0.16 ✨ Bump to controller-runtime v0.19 & controller-tools v0.16 Aug 15, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2024
chrischdi
chrischdi reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

only one question :-)

internal/apis/core/v1alpha3/condition_types.go
@@ -72,7 +72,7 @@ type Condition struct {
// Last time the condition transitioned from one status to another.
// This should be when the underlying condition changed. If that is not known, then using the time when
// the API field changed is acceptable.
// +required
// +optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New ct version makes the field required otherwise. Required marker now has a higher priority then omitempty

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more important that our CRDs don't change vs. our internal types

hack/tools/go.mod Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: af5692969e7cd2e574a890b75ff3fd5de14bf1e1

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 15, 2024 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main ea6be50 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-test-mink8s-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-mink8s-main

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 236271c into kubernetes-sigs:main Aug 15, 2024
30 of 31 checks passed
@sbueringer sbueringer deleted the pr-cr-main branch August 15, 2024 17:02
@sbueringer sbueringer mentioned this pull request Aug 19, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@elmiko elmiko Awaiting requested review from elmiko

@g-gaston g-gaston Awaiting requested review from g-gaston

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @chrischdi