-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Extend ControlPlane/ MD / MP builtin to include metadata #10837
✨ Extend ControlPlane/ MD / MP builtin to include metadata #10837
Conversation
Skipping CI for Draft Pull Request. |
The original issue only talks about |
a6a3248
to
154d4a0
Compare
exp/runtime/hooks/api/v1alpha1/topologymutation_variable_types.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
Sounds good. Let's do the same for control plane. |
bc7bbca
to
36cb449
Compare
/retitle ✨ Extend ControlPlane/Deployment/Pool builtin to include metadata |
2bdebd1
to
1fc709f
Compare
This patch extends the ControlPlane, MachineDeployment and MachinePool builtins to include metadata. Signed-off-by: Sagar Muchhal <[email protected]>
1fc709f
to
dc97411
Compare
Thank you! /lgtm |
/cherry-pick release-1.7 |
LGTM label has been added. Git tree hash: 5bf5ca63e3006fe749704f3480afb118c2d60f3e
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: #10837 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This patch extends the MachineDeployment and MachinePool builtins to include metadata from topology MachineDeployment and topology MachinePool respectively.
Which issue(s) this PR fixes:
Fixes #10836
/area clusterclass