✨ Collect additional logs with CAPD log collector #11083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/testing
k8s-ci-robot
added
the
size/S
chrischdi
reviewed
Aug 22, 2024
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
colledctadditionallogs
branch
from
9c63193
to
9b7acec
Compare
|
@chrischdi These are logs specific to K3S and RKE2 bootstrap providers. We would like them to be collected in our e2e suite that's using CAPD |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bf4d306e97cef331e294ccf4a5b9c5ef3dc1b7a9
|
chrischdi
reviewed
Aug 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I want to be able to collect more system logs from CAPD clusters than currently offered. This PR introduces a change to the DockerLogCollector structure that allows specifing additional systems logs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area testing