-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.8] 🐛 KCP: remove etcd member in pre-terminate hook #11136
[release-1.8] 🐛 KCP: remove etcd member in pre-terminate hook #11136
Conversation
2775798
to
8295a4c
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-release-1-8 |
8295a4c
to
b54d8e6
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-release-1-8 |
b54d8e6
to
9e02b83
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-release-1-8 |
/test pull-cluster-api-e2e-conformance-ci-latest-release-1-8 |
/lgtm Compared the diffs
|
LGTM label has been added. Git tree hash: 6ddafb77e3e81ad0aae5c155f45faa7b4b7e6546
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/override pull-cluster-api-e2e-blocking-release-1-8 No need to retest before merge. We only merged a doc PR in between |
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-blocking-release-1-8 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Manual cherry-pick of #11137
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #