Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Refactor the BootstrapConfig contract #11235

Merged
merged 1 commit into from
Oct 6, 2024
Merged

📖 Refactor the BootstrapConfig contract #11235

merged 1 commit into from
Oct 6, 2024

Conversation

fabriziopandini
Copy link
Member

This PR refactor the BootstrapConfig contract. Most notably

  • Everything related to the BootstrapConfig contract is now in one page, or at least in section of the book (before it was spread all around)
  • There is a table that gives an overview of all the contract rules that applies to the BootstrapConfig
  • Duplicated informations about the BootstrapConfig contract have been removed from other pages

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 27, 2024
@fabriziopandini fabriziopandini mentioned this pull request Sep 27, 2024
Open
97 tasks
chrischdi
chrischdi reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26a11f4b612a1a5bb113e104dd0a66a724b3973d

vincepri
vincepri approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 233ec90 into kubernetes-sigs:main Oct 6, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 6, 2024
@sbueringer sbueringer mentioned this pull request Oct 8, 2024
Merged
@sbueringer
Copy link
Member

/lgtm
in general, follow-up for nits here: #11274

@fabriziopandini fabriziopandini deleted the refactor-bootstrap-config-contract branch October 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@vincepri vincepri vincepri approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@fabriziopandini @k8s-ci-robot @sbueringer @chrischdi @vincepri