Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add v1beta2 OwnerRemediated condition to KCP #11297

Merged
merged 1 commit into from
Oct 21, 2024
Merged

✨ Add v1beta2 OwnerRemediated condition to KCP #11297

merged 1 commit into from
Oct 21, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Oct 16, 2024 •
edited
Loading

What this PR does / why we need it:
This PR adds code for updating v1beta2 status OwnerRemediated set by KCP on machines.

Which issue(s) this PR fixes:
Rif #11105

/area kubeadmcontrolplane

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/kubeadmcontrolplane cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
This PR adds code for updating MachineHealthCheck with v1beta2 status.
Also MachineHealthCheck now updates targeted Machines with v1beta2 status too.

Which issue(s) this PR fixes:
Rif #11105

/area kubeadmcontrolplane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@fabriziopandini fabriziopandini added area/provider/control-plane-kubeadm Issues or PRs related to KCP and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 16, 2024
@fabriziopandini fabriziopandini mentioned this pull request Oct 16, 2024
Open
97 tasks
sbueringer
sbueringer reviewed Oct 17, 2024
View reviewed changes
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/remediation.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/remediation.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/remediation.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/remediation.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-owner-remediated-condition-to-KCP branch from 57d81ed to 604d5d2 Compare October 18, 2024 14:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@sbueringer
Copy link
Member

Also feel free to squash

@fabriziopandini
Add v1beta2 OwnerRemediated condition to KCP
42bc0a6 
# Conflicts:
#	controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-owner-remediated-condition-to-KCP branch from 604d5d2 to 42bc0a6 Compare October 21, 2024 09:07
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87ad304b11db0d6da923b08725f4ccdd8254f044

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 93928cf into kubernetes-sigs:main Oct 21, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 21, 2024
@fabriziopandini fabriziopandini deleted the add-v1beta2-owner-remediated-condition-to-KCP branch November 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@g-gaston g-gaston Awaiting requested review from g-gaston

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @sbueringer