Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add more v1beta2 conditions to KCP #11320

Merged
merged 1 commit into from
Oct 24, 2024
Merged

✨ Add more v1beta2 conditions to KCP #11320

merged 1 commit into from
Oct 24, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes
Rif #11105

/area kubeadmcontrolplane

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/kubeadmcontrolplane cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Rif #11105

/area kubeadmcontrolplane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 22, 2024
@fabriziopandini fabriziopandini added area/provider/control-plane-kubeadm Issues or PRs related to KCP area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-area PR is missing an area label labels Oct 22, 2024
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@fabriziopandini fabriziopandini force-pushed the update-v1beta2-status-kcp-controller branch from 362b643 to 65dee25 Compare October 22, 2024 19:53
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2024
sbueringer
sbueringer reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped status_test.go for this iteration

api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/control_plane.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/control_plane.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
sbueringer
sbueringer reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped status_test.go for this iteration

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 23, 2024
sbueringer
sbueringer reviewed Oct 24, 2024
View reviewed changes
api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
util/collections/machine_filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status_test.go Show resolved Hide resolved
controlplane/kubeadm/internal/controllers/status_test.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the update-v1beta2-status-kcp-controller branch from 58c66f6 to d21132d Compare October 24, 2024 11:35
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main d21132d link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

sbueringer commented Oct 24, 2024 •
edited
Loading

Thx very nice work!

Especially nice that:

  • we didn't have to change the control flow in KCP
  • we cleaned up the filters, now they are pretty good :)
  • also unit tests turned out very straightforward and easy to validate

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 773e030de8e0ea2f296ce8e77fb1334095a1ab36

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0000f09 into kubernetes-sigs:main Oct 24, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 24, 2024
@fabriziopandini fabriziopandini deleted the update-v1beta2-status-kcp-controller branch November 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@enxebre enxebre Awaiting requested review from enxebre

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @sbueringer @chrischdi