Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Refine v1beta2 condition reasons #11411

Merged
merged 1 commit into from
Nov 13, 2024
Merged

🌱 Refine v1beta2 condition reasons #11411

merged 1 commit into from
Nov 13, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Nov 13, 2024 •
edited by sbueringer
Loading

What this PR does / why we need it:
Make condition reasons more consistent

/area provider/core

Part of #11105

@k8s-ci-robot k8s-ci-robot added area/provider/core Issues or PRs related to the core provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 13, 2024
sbueringer
sbueringer reviewed Nov 13, 2024
View reviewed changes
api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/cluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/machine_types.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/options.go Outdated Show resolved Hide resolved
util/conditions/v1beta2/aggregate.go Show resolved Hide resolved
internal/controllers/cluster/cluster_controller_status.go Outdated Show resolved Hide resolved
internal/controllers/cluster/cluster_controller_status.go Outdated Show resolved Hide resolved
internal/controllers/cluster/cluster_controller_status.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bf39be71e3fab8d52c005559ee80ebd4ed7c012

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 18d0cdc link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 7702621 into kubernetes-sigs:main Nov 13, 2024
22 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@enxebre enxebre Awaiting requested review from enxebre

@g-gaston g-gaston Awaiting requested review from g-gaston

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/core Issues or PRs related to the core provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @sbueringer @k8s-ci-robot