-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 e2e: Display path of the kubeconfig file for the bootstrap cluster #3596
🌱 e2e: Display path of the kubeconfig file for the bootstrap cluster #3596
Conversation
Hi @superbrothers. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @sedefsavas |
/test pull-cluster-api-test |
BTW, while running test locally, I find simpler and faster to use an existing kind cluster instead of creating one for each test run. |
I know we can use an existing kind cluster, but sometimes I want to reference a cluster for various uses, such as an Infrastructure machine creation failure. Also, I know that all objects are dumped on exit, but not all new Infrastructure providers have fully implemented phases and events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone v0.3.10
What this PR does / why we need it:
This PR displays the path of the kubeconfig file for the bootstrap cluster for E2e tests. It makes it easier to debug provider controllers if it fails to initialize the bootstrap cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #