🌱 Fix yaml file write issue in create-local-repository.py

[Jaakko-Os]

What this PR does / why we need it:
This PR fixes a file write issue in create-local-repository.py which is detected during component upgrade using clusterctl.

Which issue(s) this PR fixes

Traceback (most recent call last):
File "cmd/clusterctl/hack/create-local-repository.py", line 130, in write_local_repository
f.write(components_yaml)
TypeError: write() argument must be str, not bytes

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "cmd/clusterctl/hack/create-local-repository.py", line 241, in
repos = list(create_local_repositories())
File "cmd/clusterctl/hack/create-local-repository.py", line 162, in create_local_repositories
components_path = write_local_repository(provider, next_version, components_file, components_yaml)
File "cmd/clusterctl/hack/create-local-repository.py", line 138, in write_local_repository
raise Exception('failed to write {} to {}: {}'.format(components_file, provider_folder, e))
Exception: failed to write core-components.yaml to /home/****/.cluster-api/dev-repository/cluster-api/v0.3.8: write() argument must be str, not bytes

[k8s-ci-robot]

Hi @Jaakko-Os. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jaakko-Os]

/cc @bboreham

[k8s-ci-robot]

@Jaakko-Os: GitHub didn't allow me to request PR reviews from the following users: bboreham.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bboreham

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

Given that this reverts #3614, I would like to get @bboreham feedback here
Both versions are working fine for me...

[fabriziopandini]

/area clusterctl
/milestone v0.3.10

[fabriziopandini]

/ok-to-test

[Jaakko-Os]

Given that this reverts #3614, I would like to get @bboreham feedback here
Both versions are working fine for me...

Please note that this PR reverts https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/hack/create-local-repository.py#L129

but leaves https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/hack/create-local-repository.py#L181 unchanged

[bboreham]

Like I said, we should get someone who knows Python to comment.

[vincepri]

Wild thought 😄 , could we rewrite this simple python program in Go?

[Jaakko-Os]

$ python --version
Python 3.6.8

[Jaakko-Os]

Wild thought smile , could we rewrite this simple python program in Go?

@vincepri @bboreham @fabriziopandini could we get this issue forward to reach a solution?
I'm running controlplane component upgrade using clusterctl and this is a stopping issue for me.
I would consider the possible rewriting of 'create-local-repository.py' a sepate task.

[fabriziopandini]

I will try to give another run locally, but we should seek for a solution that works for both.

[fabriziopandini]

With the change in this PR the script works both on python 2.7.16 and python 3.8.0.
@bboreham could you kindly confirm the change works also for you?

[vincepri]

@Jaakko-Os Can you fix the commit so it doesn't include or reference a github issue or PR?

[Jaakko-Os]

@Jaakko-Os Can you fix the commit so it doesn't include or reference a github issue or PR?

done

[Jaakko-Os]

/retest

[vincepri]

/approve
/retitle 🌱 Fix yaml file write issue in create-local-repository.py
/assign @fabriziopandini

[fabriziopandini]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/clusterctl/OWNERS [fabriziopandini,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment