Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to kubeadm specific locations for kubeconfig. #492

Closed
wants to merge 1 commit into from
Closed

Conversation

davidewatson
Copy link
Contributor

Also pass --requestheader-client-ca-file to fix https://goo.gl/qZqmMb

What this PR does / why we need it:
The current apiserver manifest used by the shared deployer code makes assumptions which are not true for non-kubeadm created clusters. This causes problems when clusterctl and minikube are not used together unless the bootstrapping cluster was also created with kubeadm.

It may not be necessary to fix this given #409

This PR is mainly for documentation purposes for now.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidewatson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: medinatiger

If they are not already assigned, you can assign the PR to them by writing /assign @medinatiger in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2018
@davidewatson
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2018
@roberthbailey
Copy link
Contributor

@davidewatson - is this obsoleted by #494?

@davidewatson
Copy link
Contributor Author

It has been. Thanks for reminding me!

/close

@k8s-ci-robot
Copy link
Contributor

@davidewatson: Closing this PR.

In response to this:

It has been. Thanks for reminding me!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidewatson davidewatson deleted the apiserver branch October 4, 2018 21:05
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants