-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] 🐛 kcp: patch ImageRepository in ClusterConfiguration if it is not set for v1.25 #6957
[release-1.2] 🐛 kcp: patch ImageRepository in ClusterConfiguration if it is not set for v1.25 #6957
Conversation
/hold |
Agree with the hold. But we eventually have to merge this PR first, even if there is a follow-up bugfix. |
Test was green for @fabriziopandini : we should also either:
|
The tests on main now got green for 6 times in a row: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-e2e-main-1-24-latest 🎉 |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For reference: periodic is now green 🎉 |
This is an automated cherry-pick of #6917
/assign chrischdi