Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add issue template for Kubernetes bumps, fix links to fork #7561

Merged
merged 1 commit into from
Nov 22, 2022
Merged

📖 Add issue template for Kubernetes bumps, fix links to fork #7561

merged 1 commit into from
Nov 22, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Nov 17, 2022 •
edited
Loading

What this PR does / why we need it:
This PR documents the Kubernetes bump via an issue template and also fixes the links to my fork introduced in #7499.

Examples:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7389

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 17, 2022
@sbueringer sbueringer changed the title [DON'T REVIEW] Add issue template for Kubernetes bumps [DON'T REVIEW] [WIP] 📖 Add issue template for Kubernetes bumps Nov 17, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2022
@sbueringer sbueringer mentioned this pull request Nov 18, 2022
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2022
@sbueringer sbueringer force-pushed the pr-bump-kubernetes branch 2 times, most recently from 8ab7a36 to 4707f16 Compare November 18, 2022 07:29
@sbueringer sbueringer changed the title [DON'T REVIEW] [WIP] 📖 Add issue template for Kubernetes bumps 📖 Add issue template for Kubernetes bumps Nov 18, 2022
@sbueringer
Copy link
Member Author

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer changed the title 📖 Add issue template for Kubernetes bumps 📖 Add issue template for Kubernetes bumps, fix links to fork Nov 18, 2022
@sbueringer
Copy link
Member Author

cc @stmcginnis

@sbueringer sbueringer force-pushed the pr-bump-kubernetes branch 2 times, most recently from e717952 to 0941d5b Compare November 18, 2022 07:41
@sbueringer
Copy link
Member Author

/assign @fabriziopandini
(should be the last sub-task to close #7389)

cc @killianmuldoon @ykakarap

fabriziopandini
fabriziopandini reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last two nits, otherwise lgtm for me

.github/ISSUE_TEMPLATE/kubernetes_bump.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release_tracking.md Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-bump-kubernetes branch 2 times, most recently from bf50791 to 0eabf91 Compare November 21, 2022 04:14
@sbueringer
Copy link
Member Author

sbueringer commented Nov 21, 2022 •
edited
Loading

Updated.

I also dropped the patch version numbers for the monthly patch releases in the release timelines. I think it's only relevant that there are patch releases for certain release series, doesn't matter which ones exactly.

Otherwise it's hard to keep the exact versions up-to-date if we do additional patch releases from time to time.

@sbueringer sbueringer force-pushed the pr-bump-kubernetes branch 2 times, most recently from 7284df2 to c28fde3 Compare November 21, 2022 04:17
killianmuldoon
killianmuldoon approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
CecileRobertMichon
CecileRobertMichon reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @kubernetes-sigs/cluster-api-release-team

CecileRobertMichon
CecileRobertMichon reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

this is great, thanks @sbueringer

@hackeramitkumar
Copy link
Member

/lgtm

fabriziopandini
fabriziopandini reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
cpanato
cpanato approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oscr
Copy link
Contributor

oscr commented Nov 22, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0ba4a7a into kubernetes-sigs:main Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 22, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 22, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7584

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-bump-kubernetes branch November 22, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@cpanato cpanato cpanato approved these changes

Assignees

@cpanato cpanato

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

@hackeramitkumar hackeramitkumar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Setup initial release docs, dates and team
9 participants
@sbueringer @k8s-infra-cherrypick-robot @hackeramitkumar @k8s-ci-robot @oscr @cpanato @fabriziopandini @CecileRobertMichon @killianmuldoon