Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Use dualstack kind cluster in quick-start and startup script #8661

Merged
merged 1 commit into from
May 16, 2023
Merged

🌱 Use dualstack kind cluster in quick-start and startup script #8661

merged 1 commit into from
May 16, 2023

Conversation

killianmuldoon
Copy link
Contributor

Update the quickstart guide and kind startup script to create a dualstack kind cluster by default. This keeps parity with a change made in the CAPI e2e tests in #8517.

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2023
@killianmuldoon
Copy link
Contributor Author

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon killianmuldoon mentioned this pull request May 15, 2023
Merged
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5de099ea56e7c076e74d6bc889084d3ade6d6ae

@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor Author

/hold

Until #8517 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
chrischdi
chrischdi reviewed May 15, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ykakarap
ykakarap reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@killianmuldoon
Copy link
Contributor Author

/hold cancel
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@sbueringer
Copy link
Member

/approve

/hold
In case you want to have broader discussion around this, up to you

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@killianmuldoon
Copy link
Contributor Author

In case you want to have broader discussion around this, up to you

Should be fine - just waiting to confirm the test is passing before merging - just to get a full test run

@killianmuldoon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit f66e30f into kubernetes-sigs:main May 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 16, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 16, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8677

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

killianmuldoon pushed a commit to killianmuldoon/cluster-api that referenced this pull request May 16, 2023
@k8s-ci-robot @killianmuldoon
Merge pull request kubernetes-sigs#8661 from killianmuldoon/pr-kind-d…
36511e7 
…ualstack

🌱 Use dualstack kind cluster in quick-start and startup script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap left review comments

@chrischdi chrischdi chrischdi left review comments

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@killianmuldoon @k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @chrischdi @ykakarap