-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve release notes formatting #8826
🌱 Improve release notes formatting #8826
Conversation
/hold |
/lgtm |
LGTM label has been added. Git tree hash: 948bbe3698155702867a9afc681fb2a12e1dab58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits, otherwise lgtm for me
513526a
to
eae3326
Compare
55a1057
to
01aabab
Compare
lgtm pending rebase on top of #8817 |
* Capitalize/shorten some area labels into more legible prefixes * Remove backport PR prefixes "[release-x.x]" * Omit "num of change of type x" lines when there are no changes of that kind (eg. no breaking changes) * Handle unsync emoji and documentation area
01aabab
to
410cf44
Compare
@fabriziopandini rebased 🙌🏻 |
/lgtm |
LGTM label has been added. Git tree hash: 02dfafb5881b193171f5661642df960f572ef002
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
…ormatting-tweaks 🌱 Improve release notes formatting
What this PR does / why we need it:
A few life of quality improvements that automate manual steps performed to cleanup the release notes:
that kind (eg. no breaking changes)
documentation
to classify PRs that have the wrong emoji prefix in the title. We have seen in the past PR that use the 🐛 or 🌱 instead of 📖 , but they have thearea/documentation
label. In these cases, the label tends to be more reliable than the PR title, so this PR makes the label take precedence.I put the last item in a separate commit, since we weren't completely sure if we wanted to automate this yet and if so, what should be the logic. Opening the conversation here.
Builds on top of #8817, so this needs to wait until that's merged. Review only the last two commits pls.
/area release