Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Improve etcd management in CAPIM #8906

Merged
merged 1 commit into from
Jun 23, 2023
Merged

🌱 Improve etcd management in CAPIM #8906

merged 1 commit into from
Jun 23, 2023

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR improves etcd management in CAPIM, so it handles properly more than one control plane / etcd member joining the cluster

cc @ykakarap @killianmuldoon @sbueringer

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2023
sbueringer
sbueringer reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go Outdated Show resolved Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller_test.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member Author

/retest

@sbueringer
Copy link
Member

/lgtm
/approve

/hold
for squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ac7a3299c26cbf8de0897a35403a0fc4ac5bb0a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
killianmuldoon
killianmuldoon reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini fabriziopandini force-pushed the improve-etcd-management-in-capim branch from 22a2c21 to c54236a Compare June 23, 2023 15:35
@fabriziopandini
Copy link
Member Author

/hold cancel
after squash

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit a849996 into kubernetes-sigs:main Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 23, 2023
@fabriziopandini fabriziopandini deleted the improve-etcd-management-in-capim branch June 26, 2023 13:13
killianmuldoon
killianmuldoon reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area provider/infrastructure-inmemory

(Doesn't exist yet)

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The label(s) area/provider/infrastructure-inmemory cannot be applied, because the repository doesn't have them.

In response to this:

/area provider/infrastructure-inmemory

(Doesn't exist yet)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/area provider/infrastructure-in-memory

@k8s-ci-robot k8s-ci-robot added the area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-in-memory Issues or PRs related to the in-memory infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @killianmuldoon