-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Improve comment on MachineDeploymentStrategyType #9386
Conversation
Hi @rvanderp3. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
LGTM label has been added. Git tree hash: 501c6a75d8db94fa894f53d82838bceba304a8fe
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retitle 📖 Improve comment on MachineDeploymentStrategyType
/area documentation
Thx. Look like you also have to re-gen the openapi stuff (or just modify it manually according to the diff in the verify job, that's probably quicker) |
4ac17a3
to
ba786da
Compare
thanks @sbueringer! that update has been made and this is ready for review. |
Thank you! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 5aff723ef0f106ea44f7b5c4723270442a4cf9e9
|
What this PR does / why we need it:
This PR improves the description for the field deployment.spec.strategy.type.
Which issue(s) this PR fixes:
Fixes #9376