🌱 extend test/framework to collect workload cluster nodes #9416

rvanderp3 · 2023-09-13T13:33:08Z

What this PR does / why we need it:
Collects node yaml from workload cluster to assist in e2e failure analysis.

Which issue(s) this PR fixes:
Fixes #9250

k8s-ci-robot · 2023-09-13T13:33:18Z

Hi @rvanderp3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2023-09-13T13:33:51Z

/label area/testing

k8s-ci-robot · 2023-09-13T13:33:53Z

@rvanderp3: The label(s) /label area/testing cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label area/testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rvanderp3 · 2023-09-13T13:34:10Z

/area testing

chrischdi

All in all lgtm.

We should add a note at https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md to signal this change.

Prior art: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.3-to-v1.4.md?plain=1#L76

rvanderp3 · 2023-09-14T12:29:30Z

All in all lgtm.

We should add a note at https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md to signal this change.

Prior art: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.3-to-v1.4.md?plain=1#L76

Thanks for reviewing! I added a note.

docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md

test/framework/alltypes_helpers.go

killianmuldoon

/ok-to-test

Will be good to get a dump in the test output to see what this looks like in practice.

killianmuldoon

This is great - thankyou!

killianmuldoon · 2023-09-15T08:53:15Z

/lgtm

k8s-ci-robot · 2023-09-15T08:53:21Z

LGTM label has been added.

Git tree hash: 88304d6f30e27eec289ec1f2ff7a7e9d5b010f65

docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md

chrischdi

Last nit

/lgtm

chrischdi · 2023-09-15T10:19:23Z

Awesome work!

sbueringer

Very nice

Just two nits + #9416 (comment)

test/framework/alltypes_helpers.go

chrischdi

/lgtm

k8s-ci-robot · 2023-09-15T13:17:41Z

LGTM label has been added.

Git tree hash: c7eb703f645fcf85e1e3fca939444481a813cb80

sbueringer · 2023-09-15T13:36:06Z

Thank you very much! This will be very useful to debug e2e test issues ;)

/lgtm
/approve

k8s-ci-robot · 2023-09-15T13:36:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2023-09-19T13:39:37Z

test/framework/alltypes_helpers.go

@@ -178,7 +184,7 @@ func dumpObject(resource runtime.Object, logPath string) {
 	namespace := metaObj.GetNamespace()
 	name := metaObj.GetName()

-	resourceFilePath := filepath.Clean(path.Join(logPath, namespace, kind, name+".yaml"))
+	resourceFilePath := filepath.Clean(path.Join(logPath, kind, namespace, name+".yaml"))


I'm just trying to parse the artifacts folder and this change makes it very had:

After this change:
https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9393/pull-cluster-api-e2e-full-main/1702754124908466176/artifacts/clusters/bootstrap/resources/

Before this change:
https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-release-1-5/1704077878771060736/artifacts/clusters/bootstrap/resources/

Before it was easy to go into a folder for a namespace / test case and go through various resources. Now it's pretty hard because it's always necessary to go up and down two levels. I prefer by far the grouping by namespace and then kind over first kind and then namespace

Can we revert this change?

@killianmuldoon @chrischdi Opinions?

Fine to revert - I think you're right that namespace first is maps better onto how we've actually used this.

PR: #9462 (for reference)

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 13, 2023

k8s-ci-robot requested a review from JoelSpeed September 13, 2023 13:33

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2023

k8s-ci-robot requested a review from stmcginnis September 13, 2023 13:33

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2023

k8s-ci-robot added area/testing Issues or PRs related to testing and removed do-not-merge/needs-area PR is missing an area label labels Sep 13, 2023

chrischdi reviewed Sep 13, 2023

View reviewed changes

rvanderp3 force-pushed the ISSUE-9250 branch 2 times, most recently from 907d8ad to 029162e Compare September 13, 2023 14:17

chrischdi reviewed Sep 14, 2023

View reviewed changes

docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md Outdated Show resolved Hide resolved

test/framework/alltypes_helpers.go Outdated Show resolved Hide resolved

killianmuldoon reviewed Sep 14, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023

rvanderp3 force-pushed the ISSUE-9250 branch 2 times, most recently from 8d91fd7 to 70d947f Compare September 14, 2023 19:04

killianmuldoon reviewed Sep 15, 2023

View reviewed changes

k8s-ci-robot assigned killianmuldoon Sep 15, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023

chrischdi reviewed Sep 15, 2023

View reviewed changes

docs/book/src/developer/providers/migrations/v1.5-to-v1.6.md Outdated Show resolved Hide resolved

chrischdi reviewed Sep 15, 2023

View reviewed changes

k8s-ci-robot assigned chrischdi Sep 15, 2023

sbueringer reviewed Sep 15, 2023

View reviewed changes

test/framework/alltypes_helpers.go Outdated Show resolved Hide resolved

test/framework/alltypes_helpers.go Outdated Show resolved Hide resolved

extend test/framework to collect workload cluster nodes

edcd705

rvanderp3 force-pushed the ISSUE-9250 branch from 70d947f to edcd705 Compare September 15, 2023 13:12

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023

k8s-ci-robot requested review from chrischdi and killianmuldoon September 15, 2023 13:13

chrischdi reviewed Sep 15, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023

k8s-ci-robot assigned sbueringer Sep 15, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023

k8s-ci-robot merged commit 1735aa5 into kubernetes-sigs:main Sep 15, 2023
14 checks passed

k8s-ci-robot added this to the v1.6 milestone Sep 15, 2023

sbueringer reviewed Sep 19, 2023

View reviewed changes

sbueringer mentioned this pull request Sep 19, 2023

🌱 test/e2e: structure resources by namespace/kind again #9462

Merged

rvanderp3 mentioned this pull request Nov 2, 2023

REQUEST: New membership for rvanderp3 kubernetes/org#4572

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 extend test/framework to collect workload cluster nodes #9416

🌱 extend test/framework to collect workload cluster nodes #9416

rvanderp3 commented Sep 13, 2023

k8s-ci-robot commented Sep 13, 2023

rvanderp3 commented Sep 13, 2023

k8s-ci-robot commented Sep 13, 2023

rvanderp3 commented Sep 13, 2023

chrischdi left a comment

rvanderp3 commented Sep 14, 2023

killianmuldoon left a comment •

edited

Loading

killianmuldoon left a comment

killianmuldoon commented Sep 15, 2023

k8s-ci-robot commented Sep 15, 2023

chrischdi left a comment

chrischdi commented Sep 15, 2023

sbueringer left a comment •

edited

Loading

chrischdi left a comment

k8s-ci-robot commented Sep 15, 2023

sbueringer commented Sep 15, 2023

k8s-ci-robot commented Sep 15, 2023

sbueringer Sep 19, 2023 •

edited

Loading

killianmuldoon Sep 19, 2023

sbueringer Sep 19, 2023 •

edited

Loading

🌱 extend test/framework to collect workload cluster nodes #9416

🌱 extend test/framework to collect workload cluster nodes #9416

Conversation

rvanderp3 commented Sep 13, 2023

k8s-ci-robot commented Sep 13, 2023

rvanderp3 commented Sep 13, 2023

k8s-ci-robot commented Sep 13, 2023

rvanderp3 commented Sep 13, 2023

chrischdi left a comment

Choose a reason for hiding this comment

rvanderp3 commented Sep 14, 2023

killianmuldoon left a comment • edited Loading

Choose a reason for hiding this comment

killianmuldoon left a comment

Choose a reason for hiding this comment

killianmuldoon commented Sep 15, 2023

k8s-ci-robot commented Sep 15, 2023

chrischdi left a comment

Choose a reason for hiding this comment

chrischdi commented Sep 15, 2023

sbueringer left a comment • edited Loading

Choose a reason for hiding this comment

chrischdi left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 15, 2023

sbueringer commented Sep 15, 2023

k8s-ci-robot commented Sep 15, 2023

sbueringer Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

killianmuldoon Sep 19, 2023

Choose a reason for hiding this comment

sbueringer Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

killianmuldoon left a comment •

edited

Loading

sbueringer left a comment •

edited

Loading

sbueringer Sep 19, 2023 •

edited

Loading

sbueringer Sep 19, 2023 •

edited

Loading