-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🌱 Add log level for kube components patch to ClusterClass #9501
[release-1.5] 🌱 Add log level for kube components patch to ClusterClass #9501
Conversation
58306b6
to
572bd5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I want to do a run with the dualstack logging to be sure
/area e2e-testing
/retitle [release-1.5] 🌱 Add debug logging patch to ClusterClass |
Clusters for this run can be compared here: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/9501/pull-cluster-api-e2e-release-1-5/1706695106448330752/artifacts/clusters/ I'll revert the change in the e2e tests now. |
Signed-off-by: killianmuldoon <[email protected]>
572bd5e
to
44cbad6
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 0dcd85bee1cfb27d1660b748959729465ca430f5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manual cherry-pick of #9493