-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Change MachineHealthCheck.spec.unhealthyConditions to optional #9774
Conversation
Hi @mcbenjemaa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
38033f6
to
a846e32
Compare
Can we please include a test case for a |
a846e32
to
bb5dae1
Compare
bb5dae1
to
ffcfd8d
Compare
internal/controllers/machinehealthcheck/machinehealthcheck_targets_test.go
Outdated
Show resolved
Hide resolved
Thanks! lgtm after addressing https://github.com/kubernetes-sigs/cluster-api/pull/9774/files#r1413546275 and squashing commits. |
dd27342
to
fdd1e38
Compare
/test pull-cluster-api-test-main |
Looks like you have to run |
internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go
Outdated
Show resolved
Hide resolved
Looks like |
fdd1e38
to
79fc2ad
Compare
We had an issue in the past with running this when the repository was outside of the "GOPATH" location: #6526 But as far as I know we got this resolved. On my Ubuntu Machine I end up with the following diff after running this target: - Required: []string{"clusterName", "selector", "unhealthyConditions"},
+ Required: []string{"clusterName", "selector"}, (same as in Prow) |
@sbueringer I'm on Macos, I tried to generate in the GOPATH but still not working. this what i got:
|
This time on Apple M2 |
ready |
I would take another look once the open findings are addressed |
b0343ee
to
32764cc
Compare
@fabriziopandini will you take another look here |
32764cc
to
7c72666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small typo nits (which already did exist before) :-)
As of that I'm lgtm for this change 👍
Thanks for working on this! 🎉
internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/machinehealthcheck/machinehealthcheck_targets_test.go
Show resolved
Hide resolved
/assign @sbueringer |
@mcbenjemaa Sorry for the delay, and thank you very much for seeing this through and the patience!!! /lgtm |
LGTM label has been added. Git tree hash: 530ba36bee19420c227bb63b5ae2dda53307498a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The MHC API doesn't allow creating a health check for a missing node only,
it requires you to create fake conditions.
This PR, make the
spec.unhealthyConditions
to allow creating MHC for missing nodes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9762
/area machinehealthcheck