🐛 Fix race condition in channel source

[maxsmythe]

If multiple controllers are listening to the same channel source, Start() will be called multiple times by the manager. This causes a race condition setting cs.stop

Since cs.stop appears not to be used, it seems simplest to remove this line.

[k8s-ci-robot]

Hi @maxsmythe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/ok-to-test

[sbueringer]

Change seems fine to me

Note: Also doesn't conflict with #2159 as #2159 also drops the field. Fine for me to merge this independently

[sbueringer]

Thx!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxsmythe, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment