⚠️ Remove cache.BuilderWithOptions, and inheritance funcs #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was previously created and used to override the Manager's NewCache function. Now that the Manager embeds cache options we can remove this function and all of the inheritance logic which is highly error prone. Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Supersedes #2237 |
|
/retest |
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alvaroaleman
approved these changes
May 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
11 tasks
ary1992
added a commit
to ary1992/gardener
that referenced
this pull request
Jun 28, 2023
mkowalski
added a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 19, 2023
In kubernetes-sigs/controller-runtime#2300 the `cache.BuilderWithOptions` has been deprecated in favour of cache options embeded in the Manager. This PR rewrites our custom cache configuration to use the new way of configuring it via those new options.
mkowalski
added a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 19, 2023
In kubernetes-sigs/controller-runtime#2300 the `cache.BuilderWithOptions` has been deprecated in favour of cache options embeded in the Manager. This PR rewrites our custom cache configuration to use the new way of configuring it via those new options. Signed-off-by: Mat Kowalski <[email protected]>
mkowalski
added a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 19, 2023
In kubernetes-sigs/controller-runtime#2300 the `cache.BuilderWithOptions` has been deprecated in favour of cache options embeded in the Manager. This PR rewrites our custom cache configuration to use the new way of configuring it via those new options. Signed-off-by: Mat Kowalski <[email protected]>
mkowalski
added a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 20, 2023
In kubernetes-sigs/controller-runtime#2300 the `cache.BuilderWithOptions` has been deprecated in favour of cache options embeded in the Manager. This PR rewrites our custom cache configuration to use the new way of configuring it via those new options. Signed-off-by: Mat Kowalski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was previously created and used to override the Manager's NewCache function. Now that the Manager embeds cache options we can remove this function and all of the inheritance logic which is highly error prone.