Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 rbac: fix adding nonResourceURLs including normalisation #1044

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

chrischdi
Copy link
Member

Fixes the rbac generator for nonResourceURLs / when using kubebuilder:rbac:urls marker.

Kudos to @rakesh-garimella for reporting it at #937

This propably broke when implementing #937

@sbueringer : I think this is ok to cherry-pick?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/test pull-controller-tools-test-master

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-controller-tools-test-main

Use /test all to run all jobs.

In response to this:

Thx!

/lgtm
/approve

/test pull-controller-tools-test-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef6decf5935fc4c5b0a8fd97bf141fd7825615df

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit b00261b into kubernetes-sigs:main Aug 29, 2024
11 checks passed
@sbueringer
Copy link
Member

/cherry-pick release-0.16

@sbueringer
Copy link
Member

@rakesh-garimella Do you have some time to verify the fix on your side as well? I would then cut a new patch release

@k8s-infra-cherrypick-robot

@sbueringer: cannot checkout release-0.16: error checking out "release-0.16": exit status 1 error: pathspec 'release-0.16' did not match any file(s) known to git

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

sbueringer commented Aug 29, 2024

Just remembered that we don't always use release branches in CT, which is also the reason why we don't have one yet.

I would also cut this patch release directly from main, because apart from a few bug fixes nothing was changed on CT main since v0.16 & v0.16.1.

(we only have pre-submit jobs set up for the main branch in CT)

@rakesh-garimella
Copy link

thanks @sbueringer I will give it a try

@rakesh-garimella
Copy link

The fix works for me, thanks again @chrischdi @sbueringer

@sbueringer
Copy link
Member

Thx again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants