Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove k8s.io/kubernetes deps and switch to go modules #216

Merged
merged 7 commits into from
Feb 6, 2020
Merged

Remove k8s.io/kubernetes deps and switch to go modules #216

merged 7 commits into from
Feb 6, 2020

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Jan 25, 2020

The ultimate goal of this PR is to switch to go modules. The easiest way to do that is to break our dependency on k8s.io/kubernetes. A lot of our usage of it is relatively simple helper methods and constants that can be easily copied to our own utils package, or variables that are available in external apis anyway.

Fixes #207, #200

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2020
@damemi
Copy link
Contributor Author

damemi commented Jan 25, 2020

/cc @aveshagarwal this is what I'm thinking. It's an annoying number of helper funcs that need to just be copied over, but maybe we could just refactor their usage out anyway.

/hold
for review

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2020
@damemi
Copy link
Contributor Author

damemi commented Jan 27, 2020

/hold cancel
Looks like this builds and passes unit tests now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2020
@damemi
Copy link
Contributor Author

damemi commented Jan 29, 2020

@aveshagarwal do you have any feedback you could provide for this? It cuts down our vendored dependencies significantly, for adding only a few hundred lines of copied util functions

@damemi damemi mentioned this pull request Jan 31, 2020
Closed
@seanmalloy seanmalloy mentioned this pull request Feb 1, 2020
Closed
6 tasks
@aveshagarwal
Copy link
Contributor

@aveshagarwal do you have any feedback you could provide for this? It cuts down our vendored dependencies significantly, for adding only a few hundred lines of copied util functions

I will review it soon.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2020
soltysh
soltysh approved these changes Feb 6, 2020
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@aveshagarwal
Copy link
Contributor

@damemi have you run "go mod tidy"?

@aveshagarwal
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@damemi
Copy link
Contributor Author

damemi commented Feb 6, 2020

@damemi have you run "go mod tidy"?

@aveshagarwal yes, and I just ran it again to double check after rebasing on master. No changes

@ravisantoshgudimetla
Copy link
Contributor

/approve

@aveshagarwal - Please unhold once you're fine with the changes.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ravisantoshgudimetla]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@aveshagarwal
Copy link
Contributor

/hold off

@aveshagarwal
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit e2a23f2 into kubernetes-sigs:master Feb 6, 2020
@seanmalloy seanmalloy mentioned this pull request Feb 8, 2020
Closed
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#216 from damemi/remove-k8s-deps
a4a9f9e 
Remove k8s.io/kubernetes deps and switch to go modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to go modules.
5 participants
@damemi @aveshagarwal @ravisantoshgudimetla @k8s-ci-robot @soltysh