Add notes section to release documentation #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @aveshagarwal |
|
Super cool!!! /lgtm |
k8s-ci-robot
added
the
lgtm
aveshagarwal
reviewed
Feb 7, 2020
|
/kind documentation |
k8s-ci-robot
added
the
kind/documentation
Add a link to the test grid dashboard for automated container image builds, and documents useful gcloud commands for woking with the staging registry. This documentation is useful for project maintainers that are creating releases and publishing container images. The chance of remembering these commands and links is slim to none. Therefore documenting this information will be very useful.
The "gcloud container images describe" command is used to get the SHA256 hash of an image in the staging registry. The SHA256 hash is required for the image promotion process. https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io#image-promoter
seanmalloy
force-pushed
the
update-release-docs
branch
from
bddee1c
to
aae52ac
Compare
k8s-ci-robot
removed
the
lgtm
|
@aveshagarwal and @ravisantoshgudimetla please review when you have some time. These |
|
@seanmalloy have you checked container image paths? will lgtm once you confirm. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aveshagarwal, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@aveshagarwal yes the registry paths are all correct. The paths for the staging and prod registries are laid out differently. No typos this time. :-) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
4 tasks
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…lease-docs Add notes section to release documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a link to the test grid dashboard for automated container image builds,
and documents useful gcloud commands for woking with the staging registry.
This documentation is useful for project maintainers that are creating
releases and publishing container images. The chance of remembering
these commands and links is slim to none. Therefore documenting this
information will be very useful.