Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add damemi to approvers #277

Merged
merged 1 commit into from
May 7, 2020

Conversation

damemi
Copy link
Contributor

@damemi damemi commented May 6, 2020

I have been a reviewer for some time now and plan to remain active in the descheduler (and the rest of the scheduling sig).

I am invested in this project as part of my day job and obviously a genuine interest in seeing it grow. I believe my active status in the rest of sig-scheduling also benefits this project.

I look forward to continuing to improve the descheduler as an active maintainer and assisting and encouraging others to contribute as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2020
@damemi
Copy link
Contributor Author

damemi commented May 6, 2020

@seanmalloy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2020
@ingvagabund
Copy link
Contributor

/lgtm

@seanmalloy
Copy link
Member

/assign @ravisantoshgudimetla @aveshagarwal

@aveshagarwal
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit beae282 into kubernetes-sigs:master May 7, 2020
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants