Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert logs to use structured logging #394

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Convert logs to use structured logging #394

merged 1 commit into from
Sep 9, 2020

Conversation

farah
Copy link
Contributor

@farah farah commented Sep 4, 2020 •
edited
Loading

Fixes #347

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @farah. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2020
seanmalloy
seanmalloy requested changes Sep 4, 2020
View reviewed changes
pkg/utils/predicates.go Show resolved Hide resolved
@seanmalloy
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2020
@ingvagabund
Copy link
Contributor

LGTM so far

@seanmalloy
Copy link
Member

@farah I added two more small suggestions. After these are fixed I'll add my LGTM. Thanks!

@farah farah force-pushed the farah/add-structured-logging branch from abb3132 to e37c273 Compare September 9, 2020 14:23
@seanmalloy
Copy link
Member

/lgtm
/assign @damemi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
damemi
damemi approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, farah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1682cc9 into kubernetes-sigs:master Sep 9, 2020
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#394 from farah/farah/add-structure…
ec8dce1 
…d-logging

Convert logs to use structured logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@seanmalloy seanmalloy seanmalloy approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@seanmalloy seanmalloy

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support For Structured Logging
5 participants
@farah @k8s-ci-robot @seanmalloy @ingvagabund @damemi