Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete everything but index.yaml from gh-pages #460

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Delete everything but index.yaml from gh-pages #460

merged 1 commit into from
Dec 9, 2020

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Dec 9, 2020

This deletes everything from the gh-pages branch except for index.yaml which is used to host our helm chart index, as recommended in #436 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2020
damemi
damemi commented Dec 9, 2020
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
this isn't a total blocker now, just a cleanup. I would also like some other reviewers to double check this change for my sanity :)

/kind cleanup
/cc @seanmalloy
@stevehipwell

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 9, 2020
@seanmalloy
Copy link
Member

This looking correct to me.

  1. Merging into the correct branch(gh-pages)
  2. All files deleted except for index.yaml
  3. No changes to index.yaml

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@seanmalloy seanmalloy mentioned this pull request Dec 9, 2020
Closed
@stevehipwell
Copy link
Contributor

Looks correct to me.

@damemi
Copy link
Contributor Author

damemi commented Dec 9, 2020

/hold cancel
thanks for the review

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit e372b00 into kubernetes-sigs:gh-pages Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@k82cn k82cn Awaiting requested review from k82cn

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damemi @k8s-ci-robot @seanmalloy @stevehipwell