Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation for arm images #1815

Merged
merged 18 commits into from
Oct 15, 2020
Merged

First implementation for arm images #1815

merged 18 commits into from
Oct 15, 2020

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Oct 14, 2020

First implementation of #1443 #1721

Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
Signed-off-by: Raffaele Di Fazio <[email protected]>
@Raffo Raffo added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Raffo and others added 3 commits October 15, 2020 10:16
Co-authored-by: Nick Jüttner <[email protected]>
Co-authored-by: Nick Jüttner <[email protected]>
Co-authored-by: Nick Jüttner <[email protected]>
@Raffo
Copy link
Contributor Author

Raffo commented Oct 15, 2020

@njuettner nits accepted, not working from my editors made me do that 😅

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

let's go 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b23151c into master Oct 15, 2020
cgroschupp pushed a commit to cgroschupp/external-dns that referenced this pull request Mar 23, 2021
* multiarch init

Signed-off-by: Raffaele Di Fazio <[email protected]>

* change

Signed-off-by: Raffaele Di Fazio <[email protected]>

* codespaces

Signed-off-by: Raffaele Di Fazio <[email protected]>

* add amd64 arch

* changes

Signed-off-by: GitHub <[email protected]>

* test

Signed-off-by: Raffaele Di Fazio <[email protected]>

* changes

* ch-changes

Signed-off-by: Raffaele Di Fazio <[email protected]>

* do not install certs

Signed-off-by: Raffaele Di Fazio <[email protected]>

* save

Signed-off-by: Raffaele Di Fazio <[email protected]>

* try amd64

Signed-off-by: Raffaele Di Fazio <[email protected]>

* amd64

Signed-off-by: Raffaele Di Fazio <[email protected]>

* remove devcontainer

Signed-off-by: Raffaele Di Fazio <[email protected]>

* tests

Signed-off-by: Raffaele Di Fazio <[email protected]>

* changes

Signed-off-by: Raffaele Di Fazio <[email protected]>

* Update Makefile

Co-authored-by: Nick Jüttner <[email protected]>

* Update Makefile

Co-authored-by: Nick Jüttner <[email protected]>

* Update Makefile

Co-authored-by: Nick Jüttner <[email protected]>

Co-authored-by: Nick Jüttner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants