Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nodePort #2704 - publish ready endpoints #3447

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: nodePort #2704 - publish ready endpoints #3447

merged 2 commits into from
Sep 15, 2023

Conversation

nefelim4ag
Copy link
Contributor

@nefelim4ag nefelim4ag commented Mar 2, 2023 •
edited
Loading

Description
External-dns handles nodePort differently to Service endpoints - Ignore pod status
Implement logic to check pod status and publish only ready & running pods instead of all.

Fixes #2704

Additionally:

  • Tested on my environments, docker image: public.ecr.aws/xflow-ltd/external-dns:0.13.5

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2023
@nefelim4ag
Copy link
Contributor Author

Patched: traffic drains correctly while pods are in a Terminating state
image
Origin: traffic splits equally and breaks off on pod deletion
image

@nefelim4ag
Copy link
Contributor Author

nefelim4ag commented Apr 30, 2023 •
edited
Loading

@szuecs Sorry, if you don't mind, can I request a review?

Gentle ping: @njuettner, @seanmalloy

szuecs
szuecs requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@szuecs szuecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see all new func do not need to be expoerted, so please lower case the func name.

@szuecs
Copy link
Contributor

szuecs commented May 9, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 9, 2023
@nefelim4ag
Copy link
Contributor Author

@szuecs done

@nefelim4ag nefelim4ag requested a review from szuecs June 13, 2023 23:06
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2023
johngmyers
johngmyers suggested changes Jun 24, 2023
View reviewed changes
source/service.go Show resolved Hide resolved
source/service.go Show resolved Hide resolved
source/service.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2023
johngmyers
johngmyers approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@johngmyers
Copy link
Contributor

/assign @seanmalloy

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@nefelim4ag
Copy link
Contributor Author

@seanmalloy, @szuecs gentle ping

Just rebased on the current master.

@johngmyers
Copy link
Contributor

You generally don't need to rebase unless there are conflicts. Doing so requires others to re-review.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@mloiseleur
Copy link
Contributor

/lgtm
/assign @szuecs

@mloiseleur mloiseleur removed their assignment Sep 1, 2023
@johngmyers
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 435eb20 into kubernetes-sigs:master Sep 15, 2023
14 checks passed
@nefelim4ag nefelim4ag deleted the fix-node-ports branch November 17, 2023 02:20
@nefelim4ag nefelim4ag mentioned this pull request Dec 3, 2023
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@szuecs szuecs

@seanmalloy seanmalloy

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External-DNS: NodePort must not publish not ready pods
6 participants
@nefelim4ag @szuecs @johngmyers @mloiseleur @k8s-ci-robot @seanmalloy