-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple gloo namespaces in one External DNS instance #3480
Add support for multiple gloo namespaces in one External DNS instance #3480
Conversation
I'm not sure changing the name is the best idea. Isn't it easier to just change the behavior and document that it takes a comma-separated list? |
@esalter I'm fine with ether way as long as it does the thing. I just thought that new name would be easier to understand without even reading the docs. |
I think as long you don't break the users that have only one namespace you can update the behavior and don't change the names of the variables. Please make sure by a test that one namespace works as before and the new feature also works. |
@szuecs I used
|
Then make sure the user interface does not change because otherwise you will break users if they upgrade. |
@szuecs I changed flag name back to |
/ok-to-test |
level=warning msg="[linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649." make: *** [Makefile:51: go-lint] Error 1 |
@szuecs I removed whitespaces. Please run tests again (I checked locally - no errors). |
/ok-to-test |
Change variable type and description
Co-authored-by: John Gardiner Myers <[email protected]>
Co-authored-by: John Gardiner Myers <[email protected]>
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-external-dns-lint |
Description
Adding support for multiple gloo namespaces in one External DNS instance.
Example:
Fixes #3293
Checklist