fix: re-add api-approved.kubernetes.io annotation

[morremeyer]

Description

This re-adds the api-approved.kubernetes.io annotation that was removed with 4e6dd80.

Fixes #4487.
Fixes #4483.

I verified this locally by running

export GOBIN=/Users/morre/go/bin # on macOS
go install sigs.k8s.io/controller-tools/cmd/[email protected]

since make controller-gen did not work on my system, likely because I didn't use it correctly.

And then

make crd

to generate the CRD

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Hi @morremeyer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[morremeyer]

To whoever reviews this: Is make crd run by any CI or should I run it locally and commit the changes, too?

[mloiseleur]

@morremeyer Yes, please commit it. Can you also fix controller-gen target in the Makefile ? See #4491 if needed.

[morremeyer]

@mloiseleur Done, thank you. I'm not sure if GOBIN should be set by default, the go documentation does not look like it.

Running

export GOBIN=/Users/mmeyer/go/bin
make crd

works now.

[mloiseleur]

/ok-to-test
/lgtm

[mloiseleur]

/lgtm cancel
Yes, GOBIN can be empty. It will use ${GOPATH}/bin by default.
In fact, normally just go install xxx should do it, without all the stuff about creating directory, go mod init, ....
See my suggestion.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: morremeyer / name: morre (c0a183b)

[morremeyer]

@mloiseleur Got it, thanks. Indeed my GOPATH was not set correctly for whatever reason.

I took the liberty of fix-upping and force-pushing your suggestions to fix the CLA check.

[mloiseleur]

/lgtm

[mloiseleur]

cc @Raffo @szuecs for final review

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jetersen]

Can we have a release of this?
Stuff is still broken 😢

[Atoms]

As this is updated just in master and not in release bitnami external-dns chart is still broken, as bitnami has automatic process of crd update https://github.com/bitnami/charts/blob/main/.github/workflows/ci-pipeline.yml#L211 can we have this released as patch release?