Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointers need to be used consistently for optional fields #576

Closed
robscott opened this issue Mar 9, 2021 · 0 comments · Fixed by #579
Closed

Pointers need to be used consistently for optional fields #576

robscott opened this issue Mar 9, 2021 · 0 comments · Fixed by #579
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@robscott
Copy link
Member

robscott commented Mar 9, 2021

As noted in #564 and #572 we have not consistently been using pointers throughout this API. We should be using pointers for all fields that are optional and not a map or slice. That includes if the field has a default value.
@robscott robscott added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 9, 2021
@robscott robscott mentioned this issue Mar 9, 2021
Merged
@Hyzhou Hyzhou mentioned this issue Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the pointer for optional fields. Hyzhou/gateway-api
1 participant
@robscott