api: Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer

[stevesloka]

What type of PR is this?
/kind bug
/kind api-change

What this PR does / why we need it:

The Gateway.Spec.Listener[x].Routes.Selector is not a pointer and should be.

Which issue(s) this PR fixes:
Fixes #571

Does this PR introduce a user-facing change?:

Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer.

//cc @danehans

Signed-off-by: Steve Sloka [email protected]

[k8s-ci-robot]

Hi @stevesloka. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[stevesloka]

I'm struggling to get the docs to regen. My mac just won't get the right bits to work. Could we have an optional docker build step to run those in docker removing the need for local deps?

[robscott]

@stevesloka No need for docs generation at all anymore, we've moved to Netlify. Deploy previews are available from "deploy/preview" presubmit (this one is https://deploy-preview-572--kubernetes-sigs-gateway-api.netlify.app/).

/ok-to-test

[stevesloka]

No need for docs generation at all anymore

w00t! Thanks @robscott! =)

[robscott]

Unfortunately k8s infra doesn't like fixes keywords in commit messages so this can't be merged until that is removed. (kubernetes/test-infra#9360)

[stevesloka]

Sorry, it's a habit @robscott. I updated the commit message to remove that.

[hbagdi]

Like #564, this is another case of an optional struct should be a pointer.
We discussed previously that we need to audit the entire code to ensure this is the case.
I think we should certainly do that but such small improvements are also good.
/lgtm

[bowei]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, stevesloka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bowei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment