-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify if psuedo-headers are supported within HTTP header matching #740
Comments
Another reason: Pseudo-headers are not very popular (at least I have not encountered them for matching purposes before) so mentioning them explicitly would be helpful to users and maintainers. |
/assign |
Validation to reject pseudo headers was added in #772 |
oof, that is a good point. That validation will also need to be fixed if we are going to allow pseudo-headers. In that PR, I was slightly in favor of not allowing them in favor of explicit config, but it's not a strong preference. |
The guidance on this is now present: gateway-api/apis/v1alpha2/httproute_types.go Lines 270 to 281 in 5ac109c
/close |
@hbagdi: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What happened:
Pseudo-headers can be used to specify matches against non-header properties of HTTP requests: #733 (comment)
What you expected to happen:
The documentation of the API clarify if pseudo-headers are supported or not.
How to reproduce it (as minimally and precisely as possible):
N/A
The text was updated successfully, but these errors were encountered: