-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(conformance): shorten the resource name #2589
chore(conformance): shorten the resource name #2589
Conversation
to avoid reaching the limit of 63 characters. Signed-off-by: Jintao Zhang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tao12345666333 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this change, to be honest. I think that implementations should deal with this kind of problem and they should not expect only gateway names which length is <= 50 chars. I get the point of not destroying other implementations, but since we just released v1.0 and there likely is some time before the next release, I am not sure about mitigating this issue, since it's an implementation issue rather than an API one. @sunjayBhatia How hard is it for you to fix this problem in Contour? Do you think you'll be able to fix it in a short time or do you foresee potential compatibility issues?
I want to underline I'm 100% down on "I do not want to break implementations", and if this can happen I'm okay with this change.
We have an issue to fix this in contour already: projectcontour/contour#5970 I mainly just called it out for completeness since I had to modify the tests while reviewing to get them to pass properly with contour |
This is great! I guess this change is not needed anymore? |
Yeah I would say so 👍🏽 we can come back to this if for whatever reason we can't solve the issue in contour, but that is unlikely |
👍 Thanks anyway @tao12345666333 for promptly jumping on it. /close |
@mlavacca: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make sense. Thanks for reply. |
@tao12345666333 @mlavacca added #2592 since this actually has wider implications beyond just this test |
prevent it from destroying other projects
What type of PR is this?
/area conformance
/kind test
What this PR does / why we need it:
In Kubernetes, 63 is a very important length.
Although for Gateway resources, its name can exceed 63, different implementations may use it in different positions.
I think conformance tests should be as universal as possible to avoid encountering problems like this.
I also checked other test cases and currently, all lengths are below 50.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: