Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Docs for Fields of Type LocalObjectReference #570

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Updates Docs for Fields of Type LocalObjectReference #570

merged 1 commit into from
Mar 30, 2021

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Mar 2, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:
Updates incorrect documentation for fields of type LocalObjectRef.

Which issue(s) this PR fixes:

Fixes #569

Does this PR introduce a user-facing change?:

Fields of type LocalObjectRef do not default to "secrets". All LocalObjectRef fields must be specified.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
hbagdi
hbagdi reviewed Mar 4, 2021
View reviewed changes
apis/v1alpha1/gateway_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/backendpolicy_types.go Show resolved Hide resolved
apis/v1alpha1/httproute_types.go Show resolved Hide resolved
@danehans
Copy link
Contributor Author

@hbagdi @bowei thanks for the review. Commit e2e4886 resolves your comments.

robscott
robscott reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! Just one tiny nit but otherwise LGTM.

apis/v1alpha1/gateway_types.go Outdated Show resolved Hide resolved
@robscott robscott added this to the v0.3.0 milestone Mar 24, 2021
@danehans
Copy link
Contributor Author

@robscott commit 2fcc767 resolves your #570 (comment).

@bowei
Copy link
Contributor

bowei commented Mar 30, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f31c4bf into kubernetes-sigs:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi left review comments

@bowei bowei bowei left review comments

@robscott robscott robscott left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Archived in project
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Fields of Type LocalObjectReference Have Incorrect Documentation
5 participants
@danehans @bowei @k8s-ci-robot @robscott @hbagdi