-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying how conflicting matches should be resolved in non-HTTP Routes #626
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
48ac6c8
to
517732b
Compare
94dec5a
to
f0b7e24
Compare
I think changing "should match a maximum of one route rule" to "MUST match a maximum of one route rule" is vital. But apart from that, this looks great. |
// request matches multiple rules, matching precedence MUST be determined in | ||
// order of the following criteria, continuing on ties: | ||
// | ||
// * The longest matching SNI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to comment on how to compare wildcard strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I think "longest matching" would still be what we want even if wildcards were involved. We were missing guidance for what should be done if "*.example.com" and "b.example.com" both match - I added a new line item below this to clarify that precedence should be given to the longest precise match in the event of a tie.
Nits aside LGTM |
f0b7e24
to
6f82645
Compare
6f82645
to
4891b54
Compare
Thanks for the great feedback on this @bowei, @hbagdi, and @youngnick! I think I've resolved everything, PTAL. |
/lgtm |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
This is a follow up from #620. It takes the conflict resolution guidance we added to HTTPRoute and applies it to the other route types.
Does this PR introduce a user-facing change?:
/cc @hbagdi @youngnick