Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making Controller a required field in Route status #671

Merged
merged 1 commit into from
May 18, 2021
Merged

Making Controller a required field in Route status #671

merged 1 commit into from
May 18, 2021

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind cleanup
/kind api-change

What this PR does / why we need it:
This will help make it clear which controller populated the status. This was only alpha initially to allow for backwards compatibility within v1alpha1.

Which issue(s) this PR fixes:
Fixes #669

Does this PR introduce a user-facing change?:

Controller is now a required field in Gateway references from Route status

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott robscott added this to the v1alpha2 milestone May 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@hbagdi
Copy link
Contributor

hbagdi commented May 18, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9792a30 into kubernetes-sigs:master May 18, 2021
@robscott robscott deleted the require-controller branch January 8, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi Awaiting requested review from hbagdi

@thockin thockin Awaiting requested review from thockin

Assignees

@hbagdi hbagdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. breaking-change cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1alpha2
Development

Successfully merging this pull request may close these issues.

RouteStatusGatewayReference.Controller should have an omitempty JSON tag
3 participants
@robscott @k8s-ci-robot @hbagdi