automate nav for GEPs #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
approved
|
This works locally but Netlify blew up. can't access logs in Netlify at the moment(they might have an outage). |
jpeach
suggested changes
Aug 3, 2021
requirements.txt
Outdated
| @@ -15,3 +15,4 @@ PyYAML==5.3 | |||
| six==1.14.0 | |||
| tornado==6.0.3 | |||
| mkdocs-macros-plugin==0.4.18 | |||
| mkdocs-awesome-pages-plugin=2.5.0 | |||
There was a problem hiding this comment.
Creating a virtualenv in .venv...
Installing packages in .venv...
ERROR: Invalid requirement: 'mkdocs-awesome-pages-plugin=2.5.0' (from line 18 of requirements.txt)
Hint: = is not a valid operator. Did you mean == ?
make: *** [Makefile:107: .venv] Error 1
There was a problem hiding this comment.
Time to go for an eye check up.
Fixed.
|
Here is the preview: https://deploy-preview-744--kubernetes-sigs-gateway-api.netlify.app/ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbagdi, jpeach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Automates the nav for GEPs
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: