Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: update release-tools #812

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Aug 2, 2021

Squashed 'release-tools/' changes from 60e1cd3..c0a4fb1

c0a4fb1 Merge pull request #164 from anubha-v-ardhan/patch-1
9c6a6c0 Master to main cleanup
682c686 Merge pull request #162 from pohly/pod-name-via-shell-command
36a29f5 Merge pull request #163 from pohly/remove-bazel
68e43ca prow.sh: remove Bazel build support
c5f59c5 prow.sh: allow shell commands in CSI_PROW_SANITY_POD
71c810a Merge pull request #161 from pohly/mock-test-fixes
9e438f8 prow.sh: fix mock testing
d7146c7 Merge pull request #160 from pohly/kind-update
4b6aa60 prow.sh: update to KinD v0.11.0
7cdc76f Merge pull request #159 from pohly/fix-deployment-selection
ef8bd33 prow.sh: more flexible CSI_PROW_DEPLOYMENT, part II
204bc89 Merge pull request #158 from pohly/fix-deployment-selection
61538bb prow.sh: more flexible CSI_PROW_DEPLOYMENT
2b0e6db Merge pull request #157 from humblec/csi-release
a2fcd6d Adding myself to csi reviewers group
f325590 Merge pull request #149 from pohly/cluster-logs
4b03b30 Merge pull request #155 from pohly/owners
a6453c8 owners: introduce aliases
ad83def Merge pull request #153 from pohly/fix-image-builds
5561780 build.make: fix image publishng
29bd39b Merge pull request #152 from pohly/bump-csi-test
bc42793 prow.sh: use csi-test v4.2.0
b546baa Merge pull request #150 from mauriciopoppe/windows-multiarch-args
bfbb6f3 add parameter base_image and addon_image to BUILD_PARAMETERS
2d61d3b Merge pull request #151 from humblec/cm
48e71f0 Replace which command ( non standard) with command -v builtin
feb20e2 prow.sh: collect cluster logs
7b96bea Merge pull request #148 from dobsonj/add-checkpathcmd-to-prow
2d2e03b prow.sh: enable -csi.checkpathcmd option in csi-sanity
09d4151 Merge pull request #147 from pohly/mock-testing
74cfbc9 prow.sh: support mock tests
4a3f110 prow.sh: remove obsolete test suppression
6616a6b Merge pull request #146 from pohly/kubernetes-1.21
510fb0f prow.sh: support Kubernetes 1.21
c63c61b prow.sh: add CSI_PROW_DEPLOYMENT_SUFFIX
51ac11c Merge pull request #144 from pohly/pull-jobs
dd54c92 pull-test.sh: test importing csi-release-tools into other repo
7d2643a Merge pull request #143 from pohly/path-setup
6880b0c prow.sh: avoid creating paths unless really running tests
bc0504a Merge pull request #140 from jsafrane/remove-unused-k8s-libs
5b1de1a go-get-kubernetes.sh: remove unused k8s libs
49b4269 Merge pull request #120 from pohly/add-kubernetes-release
a1e1127 Merge pull request #139 from pohly/kind-for-kubernetes-latest
1c0fb09 prow.sh: use KinD main for latest Kubernetes
1d77cfc Merge pull request #138 from pohly/kind-update-0.10
bff2fb7 prow.sh: KinD 0.10.0
95eac33 Merge pull request #137 from pohly/fix-go-version-check
437e431 verify-go-version.sh: fix check after removal of travis.yml
1748b16 Merge pull request #136 from pohly/go-1.16
ec844ea remove travis.yml, Go 1.16
df76aba Merge pull request #134 from andyzhangx/add-build-arg
e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3
7bc70e5 Merge pull request #129 from pohly/squash-documentation
e0b02e7 README.md: document usage of --squash
316cb95 Merge pull request #132 from yiyang5055/bugfix/boilerplate
26e2ab1 fix: default boilerplate path
1add8c1 Merge pull request #133 from pohly/kubernetes-1.20-tag
3e811d6 prow.sh: fix "on-master" prow jobs
1d60e77 Merge pull request #131 from pohly/kubernetes-1.20-tag
9f10459 prow.sh: support building Kubernetes for a specific version
f7e7ee4 docs: steps for adding testing against new Kubernetes release
fe1f284 Merge pull request #121 from kvaps/namespace-check
8fdf0f7 Merge pull request #128 from fengzixu/master
1c94220 fix: fix a bug of csi-sanity
a4c41e6 Merge pull request #127 from pohly/fix-boilerplate
ece0f50 check namespace for snapshot-controller
dbd8967 verify-boilerplate.sh: fix path to script
9289fd1 Merge pull request #125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
ad29307 Make the spelling and boilerplate checks optional
5f06d02 Merge pull request #124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eb Fix spelling and boilerplate errors
71690af Merge pull request #122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3f Adding spelling and boilerplate checks.
2bb7525 Merge pull request #117 from fengzixu/master
3b6d17b Merge pull request #118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request #116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name
c6a88c6 Merge pull request #113 from xing-yang/install_snapshot_controller
45ec4c6 Fix the install of snapshot CRDs and controller
5d874cc Merge pull request #112 from xing-yang/cleanup
79bbca7 Cleanup
d437673 Merge pull request #111 from xing-yang/update_snapshot_v1_rc
57718f8 Update snapshot CRD version
4aff857 Merge pull request #109 from pohly/alpha-test-defaults
0427289 Merge pull request #110 from pohly/kind-0.9-bazel-build-workaround
9a370ab prow.sh: work around "kind build node-image" failure
522361e prow.sh: only run alpha tests for latest Kubernetes release
22c0395 Merge pull request #108 from bnrjee/master
b5b447b Add go ldflags using LDFLAGS at the time of compilation
16f4afb Merge pull request #107 from pohly/kind-update
7bcee13 prow.sh: update to kind 0.9, support Kubernetes 1.19
df518fb prow.sh: usage of Bazel optional
c3afd42 Merge pull request #104 from xing-yang/snapshot
dde93b2 Update to snapshot-controller v3.0.0
a0f195c Merge pull request #106 from msau42/fix-canary
7100c12 Only set staging registry when running canary job
b3c65f9 Merge pull request #99 from msau42/add-release-process
e53f3e8 Merge pull request #103 from msau42/fix-canary
d129462 Document new method for adding CI jobs are new K8s versions
e73c2ce Use staging registry for canary tests
2c09846 Add cleanup instructions to release-notes generation

git-subtree-dir: release-tools
git-subtree-split: c0a4fb1dd00b02879dbcea987e2e9524e4f5a905

NONE

kubernetes-csi/csi-release-tools@c0a4fb1 Merge kubernetes-csi/csi-release-tools#164 from anubha-v-ardhan/patch-1
kubernetes-csi/csi-release-tools@9c6a6c0 Master to main cleanup
kubernetes-csi/csi-release-tools@682c686 Merge kubernetes-csi/csi-release-tools#162 from pohly/pod-name-via-shell-command
kubernetes-csi/csi-release-tools@36a29f5 Merge kubernetes-csi/csi-release-tools#163 from pohly/remove-bazel
kubernetes-csi/csi-release-tools@68e43ca prow.sh: remove Bazel build support
kubernetes-csi/csi-release-tools@c5f59c5 prow.sh: allow shell commands in CSI_PROW_SANITY_POD
kubernetes-csi/csi-release-tools@71c810a Merge kubernetes-csi/csi-release-tools#161 from pohly/mock-test-fixes
kubernetes-csi/csi-release-tools@9e438f8 prow.sh: fix mock testing
kubernetes-csi/csi-release-tools@d7146c7 Merge kubernetes-csi/csi-release-tools#160 from pohly/kind-update
kubernetes-csi/csi-release-tools@4b6aa60 prow.sh: update to KinD v0.11.0
kubernetes-csi/csi-release-tools@7cdc76f Merge kubernetes-csi/csi-release-tools#159 from pohly/fix-deployment-selection
kubernetes-csi/csi-release-tools@ef8bd33 prow.sh: more flexible CSI_PROW_DEPLOYMENT, part II
kubernetes-csi/csi-release-tools@204bc89 Merge kubernetes-csi/csi-release-tools#158 from pohly/fix-deployment-selection
kubernetes-csi/csi-release-tools@61538bb prow.sh: more flexible CSI_PROW_DEPLOYMENT
kubernetes-csi/csi-release-tools@2b0e6db Merge kubernetes-csi/csi-release-tools#157 from humblec/csi-release
kubernetes-csi/csi-release-tools@a2fcd6d Adding myself to csi reviewers group
kubernetes-csi/csi-release-tools@f325590 Merge kubernetes-csi/csi-release-tools#149 from pohly/cluster-logs
kubernetes-csi/csi-release-tools@4b03b30 Merge kubernetes-csi/csi-release-tools#155 from pohly/owners
kubernetes-csi/csi-release-tools@a6453c8 owners: introduce aliases
kubernetes-csi/csi-release-tools@ad83def Merge kubernetes-csi/csi-release-tools#153 from pohly/fix-image-builds
kubernetes-csi/csi-release-tools@5561780 build.make: fix image publishng
kubernetes-csi/csi-release-tools@29bd39b Merge kubernetes-csi/csi-release-tools#152 from pohly/bump-csi-test
kubernetes-csi/csi-release-tools@bc42793 prow.sh: use csi-test v4.2.0
kubernetes-csi/csi-release-tools@b546baa Merge kubernetes-csi/csi-release-tools#150 from mauriciopoppe/windows-multiarch-args
kubernetes-csi/csi-release-tools@bfbb6f3 add parameter base_image and addon_image to BUILD_PARAMETERS
kubernetes-csi/csi-release-tools@2d61d3b Merge kubernetes-csi/csi-release-tools#151 from humblec/cm
kubernetes-csi/csi-release-tools@48e71f0 Replace `which` command ( non standard)  with `command -v` builtin
kubernetes-csi/csi-release-tools@feb20e2 prow.sh: collect cluster logs
kubernetes-csi/csi-release-tools@7b96bea Merge kubernetes-csi/csi-release-tools#148 from dobsonj/add-checkpathcmd-to-prow
kubernetes-csi/csi-release-tools@2d2e03b prow.sh: enable -csi.checkpathcmd option in csi-sanity
kubernetes-csi/csi-release-tools@09d4151 Merge kubernetes-csi/csi-release-tools#147 from pohly/mock-testing
kubernetes-csi/csi-release-tools@74cfbc9 prow.sh: support mock tests
kubernetes-csi/csi-release-tools@4a3f110 prow.sh: remove obsolete test suppression
kubernetes-csi/csi-release-tools@6616a6b Merge kubernetes-csi/csi-release-tools#146 from pohly/kubernetes-1.21
kubernetes-csi/csi-release-tools@510fb0f prow.sh: support Kubernetes 1.21
kubernetes-csi/csi-release-tools@c63c61b prow.sh: add CSI_PROW_DEPLOYMENT_SUFFIX
kubernetes-csi/csi-release-tools@51ac11c Merge kubernetes-csi/csi-release-tools#144 from pohly/pull-jobs
kubernetes-csi/csi-release-tools@dd54c92 pull-test.sh: test importing csi-release-tools into other repo
kubernetes-csi/csi-release-tools@7d2643a Merge kubernetes-csi/csi-release-tools#143 from pohly/path-setup
kubernetes-csi/csi-release-tools@6880b0c prow.sh: avoid creating paths unless really running tests
kubernetes-csi/csi-release-tools@bc0504a Merge kubernetes-csi/csi-release-tools#140 from jsafrane/remove-unused-k8s-libs
kubernetes-csi/csi-release-tools@5b1de1a go-get-kubernetes.sh: remove unused k8s libs
kubernetes-csi/csi-release-tools@49b4269 Merge kubernetes-csi/csi-release-tools#120 from pohly/add-kubernetes-release
kubernetes-csi/csi-release-tools@a1e1127 Merge kubernetes-csi/csi-release-tools#139 from pohly/kind-for-kubernetes-latest
kubernetes-csi/csi-release-tools@1c0fb09 prow.sh: use KinD main for latest Kubernetes
kubernetes-csi/csi-release-tools@1d77cfc Merge kubernetes-csi/csi-release-tools#138 from pohly/kind-update-0.10
kubernetes-csi/csi-release-tools@bff2fb7 prow.sh: KinD 0.10.0
kubernetes-csi/csi-release-tools@95eac33 Merge kubernetes-csi/csi-release-tools#137 from pohly/fix-go-version-check
kubernetes-csi/csi-release-tools@437e431 verify-go-version.sh: fix check after removal of travis.yml
kubernetes-csi/csi-release-tools@1748b16 Merge kubernetes-csi/csi-release-tools#136 from pohly/go-1.16
kubernetes-csi/csi-release-tools@ec844ea remove travis.yml, Go 1.16
kubernetes-csi/csi-release-tools@df76aba Merge kubernetes-csi/csi-release-tools#134 from andyzhangx/add-build-arg
kubernetes-csi/csi-release-tools@e314a56 add build-arg ARCH for building multi-arch images, e.g. ARG ARCH FROM k8s.gcr.io/build-image/debian-base-${ARCH}:v2.1.3
kubernetes-csi/csi-release-tools@7bc70e5 Merge kubernetes-csi/csi-release-tools#129 from pohly/squash-documentation
kubernetes-csi/csi-release-tools@e0b02e7 README.md: document usage of --squash
kubernetes-csi/csi-release-tools@316cb95 Merge kubernetes-csi/csi-release-tools#132 from yiyang5055/bugfix/boilerplate
kubernetes-csi/csi-release-tools@26e2ab1 fix: default boilerplate path
kubernetes-csi/csi-release-tools@1add8c1 Merge kubernetes-csi/csi-release-tools#133 from pohly/kubernetes-1.20-tag
kubernetes-csi/csi-release-tools@3e811d6 prow.sh: fix "on-master" prow jobs
kubernetes-csi/csi-release-tools@1d60e77 Merge kubernetes-csi/csi-release-tools#131 from pohly/kubernetes-1.20-tag
kubernetes-csi/csi-release-tools@9f10459 prow.sh: support building Kubernetes for a specific version
kubernetes-csi/csi-release-tools@f7e7ee4 docs: steps for adding testing against new Kubernetes release
kubernetes-csi/csi-release-tools@fe1f284 Merge kubernetes-csi/csi-release-tools#121 from kvaps/namespace-check
kubernetes-csi/csi-release-tools@8fdf0f7 Merge kubernetes-csi/csi-release-tools#128 from fengzixu/master
kubernetes-csi/csi-release-tools@1c94220 fix: fix a bug of csi-sanity
kubernetes-csi/csi-release-tools@a4c41e6 Merge kubernetes-csi/csi-release-tools#127 from pohly/fix-boilerplate
kubernetes-csi/csi-release-tools@ece0f50 check namespace for snapshot-controller
kubernetes-csi/csi-release-tools@dbd8967 verify-boilerplate.sh: fix path to script
kubernetes-csi/csi-release-tools@9289fd1 Merge kubernetes-csi/csi-release-tools#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
kubernetes-csi/csi-release-tools@ad29307 Make the spelling and boilerplate checks optional
kubernetes-csi/csi-release-tools@5f06d02 Merge kubernetes-csi/csi-release-tools#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
kubernetes-csi/csi-release-tools@48186eb Fix spelling and boilerplate errors
kubernetes-csi/csi-release-tools@71690af Merge kubernetes-csi/csi-release-tools#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
kubernetes-csi/csi-release-tools@981be3f Adding spelling and boilerplate checks.
kubernetes-csi/csi-release-tools@2bb7525 Merge kubernetes-csi/csi-release-tools#117 from fengzixu/master
kubernetes-csi/csi-release-tools@3b6d17b Merge kubernetes-csi/csi-release-tools#118 from pohly/cloud-build-timeout
kubernetes-csi/csi-release-tools@9318c6c cloud build: double the timeout, now 1 hour
kubernetes-csi/csi-release-tools@4ab8b15 use the tag to replace commit of csi-test
kubernetes-csi/csi-release-tools@5d74e45 change the csi-test import path to v4
kubernetes-csi/csi-release-tools@7dcd0a9 upgrade csi-test to v4.0.2
kubernetes-csi/csi-release-tools@86ff580 Merge kubernetes-csi/csi-release-tools#116 from andyzhangx/export-image-name
kubernetes-csi/csi-release-tools@c3a9662 allow export image name and registry name
kubernetes-csi/csi-release-tools@c6a88c6 Merge kubernetes-csi/csi-release-tools#113 from xing-yang/install_snapshot_controller
kubernetes-csi/csi-release-tools@45ec4c6 Fix the install of snapshot CRDs and controller
kubernetes-csi/csi-release-tools@5d874cc Merge kubernetes-csi/csi-release-tools#112 from xing-yang/cleanup
kubernetes-csi/csi-release-tools@79bbca7 Cleanup
kubernetes-csi/csi-release-tools@d437673 Merge kubernetes-csi/csi-release-tools#111 from xing-yang/update_snapshot_v1_rc
kubernetes-csi/csi-release-tools@57718f8 Update snapshot CRD version
kubernetes-csi/csi-release-tools@4aff857 Merge kubernetes-csi/csi-release-tools#109 from pohly/alpha-test-defaults
kubernetes-csi/csi-release-tools@0427289 Merge kubernetes-csi/csi-release-tools#110 from pohly/kind-0.9-bazel-build-workaround
kubernetes-csi/csi-release-tools@9a370ab prow.sh: work around "kind build node-image" failure
kubernetes-csi/csi-release-tools@522361e prow.sh: only run alpha tests for latest Kubernetes release
kubernetes-csi/csi-release-tools@22c0395 Merge kubernetes-csi/csi-release-tools#108 from bnrjee/master
kubernetes-csi/csi-release-tools@b5b447b Add go ldflags using LDFLAGS at the time of compilation
kubernetes-csi/csi-release-tools@16f4afb Merge kubernetes-csi/csi-release-tools#107 from pohly/kind-update
kubernetes-csi/csi-release-tools@7bcee13 prow.sh: update to kind 0.9, support Kubernetes 1.19
kubernetes-csi/csi-release-tools@df518fb prow.sh: usage of Bazel optional
kubernetes-csi/csi-release-tools@c3afd42 Merge kubernetes-csi/csi-release-tools#104 from xing-yang/snapshot
kubernetes-csi/csi-release-tools@dde93b2 Update to snapshot-controller v3.0.0
kubernetes-csi/csi-release-tools@a0f195c Merge kubernetes-csi/csi-release-tools#106 from msau42/fix-canary
kubernetes-csi/csi-release-tools@7100c12 Only set staging registry when running canary job
kubernetes-csi/csi-release-tools@b3c65f9 Merge kubernetes-csi/csi-release-tools#99 from msau42/add-release-process
kubernetes-csi/csi-release-tools@e53f3e8 Merge kubernetes-csi/csi-release-tools#103 from msau42/fix-canary
kubernetes-csi/csi-release-tools@d129462 Document new method for adding CI jobs are new K8s versions
kubernetes-csi/csi-release-tools@e73c2ce Use staging registry for canary tests
kubernetes-csi/csi-release-tools@2c09846 Add cleanup instructions to release-notes generation

git-subtree-dir: release-tools
git-subtree-split: c0a4fb1dd00b02879dbcea987e2e9524e4f5a905
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 2, 2021
@msau42
Copy link
Contributor

msau42 commented Aug 2, 2021

@pohly looks like we need to add everyone that is a kubernetes-csi owner into the kubernetes-sigs org?

This is needed for the OWNERS file in release-tools.
@pohly
Copy link
Contributor Author

pohly commented Aug 2, 2021

@pohly looks like we need to add everyone that is a kubernetes-csi owner into the kubernetes-sigs org?

No, I think I just need to add the OWNERS_ALIAS symlink in this PR.

However, I see that @mattcary hasn't fixed the release-tools import yet (see https://kubernetes.slack.com/archives/C8EJ01Z46/p1625582445261000?thread_ts=1625561455.251000&cid=C8EJ01Z46).

Is it okay if I just close this PR and let you guys handle gcp-compute-persistent-disk-csi-driver?

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2021
@pohly
Copy link
Contributor Author

pohly commented Aug 2, 2021

No, I think I just need to add the OWNERS_ALIAS symlink in this PR.

I added that - let's see whether it now passes the check.

@pohly
Copy link
Contributor Author

pohly commented Aug 25, 2021

/assign @msau42

Please let me know whether I should continue to push changes with PRs like this or whether you prefer to pull.

@msau42
Copy link
Contributor

msau42 commented Aug 25, 2021

/lgtm
/approve

It doesn't look like we run verify tests on release-tools so we can fix the release-tools import issue separately. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@msau42
Copy link
Contributor

msau42 commented Aug 25, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2021
@msau42
Copy link
Contributor

msau42 commented Aug 25, 2021

hm @mauriciopoppe do you know about this windows bulid lint failures?

@mauriciopoppe
Copy link
Member

@msau42 yes, I think it's related with https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md, on go fmt my editor added the //go:build <platform> line but I removed it manually before merging #738,
I've also seen this in kubernetes-csi/node-driver-registrar#133 (comment)

Anyways I created #827 adding the missing lines

@mauriciopoppe
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit c2cdd84 into kubernetes-sigs:master Aug 25, 2021
@pohly pohly deleted the prow-update-master branch November 30, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants